Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with nested menu items #16450

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

Ruslan-Aleev
Copy link
Collaborator

@Ruslan-Aleev Ruslan-Aleev commented Jun 19, 2023

What does it do?

Add new system setting topmenu_subitems_max to be able to restrict the dropdown menu.
Sometimes a large number of installed packages prevent the normal use of the menu.

Why is it needed?

Description from #11939

When there's a long Extras dropdown menu, and not enough screen space, the bottom items get cut off. It's not possible to scroll down or access them.

How it looks (set to 3):
menu_more_fix

Related issue(s)/PR(s)

#11939
#14300
#15817

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Jun 19, 2023
@Ruslan-Aleev Ruslan-Aleev added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. pr/review-needed Pull request requires review and testing. pr/port-to-3 Pull request has to be ported to 3.x. labels Jun 19, 2023
@Ruslan-Aleev Ruslan-Aleev added this to the v2.8.6 milestone Jun 19, 2023
@Ruslan-Aleev Ruslan-Aleev added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Aug 7, 2023
@opengeek opengeek merged commit fa690a3 into modxcms:2.x Sep 27, 2023
5 checks passed
@Ruslan-Aleev Ruslan-Aleev deleted the 2.x-feature-11939 branch September 28, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/port-to-3 Pull request has to be ported to 3.x. pr/ready-for-merging Pull request reviewed and tested and ready for merging. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants